dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.
http://dgl.ai
Apache License 2.0
13.36k stars 3k forks source link

[GraphBolt] Add `gb.numpy_save_aligned`. #7524

Closed mfbalin closed 2 months ago

mfbalin commented 2 months ago

Description

If we store our features in the numpy format using this new function, our io_uring and mmap disk read operations will speedup significantly (2.1 GiB/s vs 1.7 GiB/s) for nice close to power of 2 embedding sizes such as 768 floats or 512 int8s

It is risk free to do this change because the files that we handle are a lot larger than 4K.

Checklist

Please feel free to remove inapplicable items for your PR.

Changes

dgl-bot commented 2 months ago

To trigger regression tests:

dgl-bot commented 2 months ago

Commit ID: 24804be09579ab432cd52e568afb7220b5c247b3

Build ID: 1

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 74d8d9d3dd50825c74dd44a3f0f0590972661022

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 66c46636f5b3ae9ecfd073a60fd84a941206a6f0

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

mfbalin commented 2 months ago

Finished working on the PR.

dgl-bot commented 2 months ago

Commit ID: e139b9d50545933d4d02f436510f258742965843

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 3052e6c4ea5ea02de021de9a437d7d8826cd14da

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: d35bb20fa82f3f67435c4de3ea9152fb45eeba1b

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 872b7a2d5a9b5a9e4d851f697135399d848ceedf

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 7f19f91c22b20f2a0d54c69aa5f93bc6efa8b61e

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link