[GraphBolt][CUDA] Add `FeatureCache::IndexSelect`. - Githubissues

dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.

http://dgl.ai

Apache License 2.0

13.36k stars 3k forks source link

[GraphBolt][CUDA] Add `FeatureCache::IndexSelect`. #7526

Closed mfbalin closed 2 months ago

mfbalin commented 2 months ago

Description

This op is needed for zero copy access from the GPU. GPU reading tests will be included in a follow-up PR when I make use of this added functionality.

Checklist

Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[ ] I've leverage the tools to beautify the python and c++ code.
[ ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
[ ] All changes have test coverage
[ ] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

dgl-bot commented 2 months ago

To trigger regression tests:

@dgl-bot run [instance-type] [which tests] [compare-with-branch]; For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot commented 2 months ago

Commit ID: 3c0ed42b8153ef074665864022babba7aeda156f

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: b46561da57ecf92bff8a9d932841300536ccc27c

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: e5553f84a8210483415dd92ac7beba879e5ed0f4

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: ec688f794dd763eae7052e7a02d7c17d393e9c7c

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: dca0aca8eaabacb9d565c3dec5f7d02176172462

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: 08216c1f55b0f3764623636bfb268be6fddd2d1d

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 2 months ago

Commit ID: f612ac612e41e4cf9994bd4bb123aeee88791886

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

frozenbugs commented 2 months ago

Index select and pin memory are not related, could be 2 small prs.

mfbalin commented 2 months ago

Index select and pin memory are not related, could be 2 small prs.

Indeed.