dmlc / dgl

Python package built to ease deep learning on graph, on top of existing DL frameworks.
http://dgl.ai
Apache License 2.0
13.36k stars 3k forks source link

[GraphBolt] Refactor and extend `FeatureStore`. #7558

Closed mfbalin closed 1 month ago

mfbalin commented 1 month ago

Description

We don't need to expose Feature.read_async and related functions in FeatureStore. This functionality will let us access the stored Features in FeatureFetcher and we will be able to call the hidden read_async functions as the user will mostly keep FeatureStore objects around, not Features. Moreover, it is possible to provide the implementations of read, update and other functions if we expose a __getitem__ method, increasing code reuse.

It will also make the examples look better and our components easier to use. https://github.com/dmlc/dgl/blob/69fd95e370fb935dbce9896ad56165b8097dcd3e/examples/multigpu/graphbolt/node_classification.py#L299-L303

Checklist

Please feel free to remove inapplicable items for your PR.

Changes

dgl-bot commented 1 month ago

To trigger regression tests:

dgl-bot commented 1 month ago

Commit ID: 6689153f0c907b06b8f4e58b32948d291065c14d

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 1 month ago

Commit ID: cad4b6e875a2f22f989bc8ba8dd6bf2448211380

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot commented 1 month ago

Commit ID: 060001d66920f58b361debd314b10420f6bcf493

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 1 month ago

Commit ID: ce5870e767c5f0294e77ed99bc730ded9e28a5f4

Build ID: 4

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot commented 1 month ago

Commit ID: 725b17c3a442b97b325fac0d327495c61e37616a

Build ID: 5

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot commented 1 month ago

Commit ID: ea35d4f2a32a35bd39861b2e882c419512c88fab

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot commented 1 month ago

Commit ID: a3324cd252dade318c1e545306cbe1e002a577b6

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link