search

dmlc / dlpack

common in-memory tensor structure
https://dmlc.github.io/dlpack/latest
Apache License 2.0
911 stars 133 forks source link

[RFC] [DeviceType] Add support for MAIA #120

Closed kyule7 closed 10 months ago

kyule7 commented 1 year ago

This PR extends DLDeviceType to support Microsoft MAIA devices.

tqchen commented 1 year ago

Thanks @kyule7 . Would like to get a bit more background on about this device type, is there any public available information that describes the proposed device?

kyule7 commented 1 year ago

Thanks @kyule7 . Would like to get a bit more background on about this device type, is there any public available information that describes the proposed device?

I do not think there is any good public information about the device, so it is difficult to describe any background and details about it at the moment. Would extending DLDeviceType require any public knowledge about the device?

tqchen commented 1 year ago

@kyule7 usually yes, since one goal of DLPack to be stable and widely used, so we would like to maintain a list of public available devices for that purpose. DLExtDevice would serve as a good middle ground for plug in less mature device requirements

kyule7 commented 1 year ago

@kyule7 usually yes, since one goal of DLPack to be stable and widely used, so we would like to maintain a list of public available devices for that purpose. DLExtDevice would serve as a good middle ground for plug in less mature device requirements

I used DLExtDevice for experiment with a new device for functionality, and planned to extend dlpack first in order to extend the dependent frameworks for the device support. I will close this PR since I do not think any public information about the device is available currently.

tqchen commented 1 year ago

thanks @kyule7 you are more than welcome to bring up followups once it is publicly available

kyule7 commented 1 year ago

Reopening it since Maia 100 is publicly announced.

tqchen commented 11 months ago

gentle ping @kyule7 :)

kyule7 commented 10 months ago

Could anyone help merging this PR?

tqchen commented 10 months ago

Thanks @kyule7 this is now merged

edgarriba commented 10 months ago

@tqchen worth to release ?

leofang commented 9 months ago

There're a few changes from the Array API side that we're wrapping up, would be nice to hold off a bit 🙂

leofang commented 9 months ago

btw I noticed the doc build CI has been failing for some time (perhaps before this PR). Fixing it in #136.

kyule7 commented 9 months ago

@tqchen worth to release ?

@edgarriba Would like to apply this change in the dependent framework repos (pytorch and onnxruntime), would there be any chance to have a new release including this PR change?

leofang commented 9 months ago

Hi, v1.0rc is out a few days ago, could you give it a try? https://github.com/dmlc/dlpack/releases/tag/v1.0rc