Declare the type name of `int64_t`

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.

Apache License 2.0

864 stars 520 forks source link

Closed wkcn closed 5 years ago

wkcn commented 5 years ago

In MXNet, dim_t is the type of some parameters, like mx.nd.eye.

However, dim_t couldn't be parsed into a string, since dim_t is the alias of int64_t, which is not registed by dmlc-core type-traits.

In this PR, I declare the type name of int64_t.

wkcn commented 5 years ago

@hcho3 Thank you!

I have a question whether it is necessary to declare other types, such as char, short?

hcho3 commented 5 years ago

@wkcn I have no idea. I'm assuming this PR is sufficient for your use case though?

wkcn commented 5 years ago

@hcho3 Yes, this PR is sufficient for my use case.