dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.
Apache License 2.0
864 stars 520 forks source link

Fix data race and thread leak in ThreadedIter #554

Closed hcho3 closed 5 years ago

hcho3 commented 5 years ago

Fixes #550

cc @larroy @jermainewang

jermainewang commented 5 years ago

Consider enable sanitizer in the CI after these fixes?

hcho3 commented 5 years ago

@jermainewang There's still a long way to go until we resolve all errors reported by the Sanitizer: #553

trivialfis commented 5 years ago

We can fix them one by one?

hcho3 commented 5 years ago

@trivialfis Yes, I plan to merge this PR pretty soon (after addressing comments from @junrushao1994), and then tackle remaining concurrency issues in subsequent PRs.

hcho3 commented 5 years ago

@trivialfis Since there are outstanding concurrency issues, I'm afraid we are not yet able to add sanitizer to CI.

hcho3 commented 5 years ago

@trivialfis For now, I added the sanitizer test and marked it non-blocking.