Fix include/dmlc/omp.h for clang

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.

Apache License 2.0

864 stars 520 forks source link

Fix include/dmlc/omp.h for clang #582

Closed leezu closed 4 years ago

leezu commented 4 years ago

__GOMP_NOTHROW does not make sense when building with clang. I'm not sure why the previous condition assumes defined(__ANDROID__) && defined (__clang__). It doesn't matter if were building for Android or just building with clang.

CC @larroy

larroy commented 4 years ago

Android started using clang after some release of the NDK, not before. I think that's the origin of that. This might break build with older NDKs.

leezu commented 4 years ago

So the condition should just be clang? I'm not sure why the android condition was added in the first place then?

larroy commented 4 years ago

Because it failed in android. Maybe it should be just clang, don't know by heart now.