search

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.
Apache License 2.0
864 stars 520 forks source link

flake8 checks not enforced #599

Open leezu opened 4 years ago

leezu commented 4 years ago

CI currently runs flake8 on every run

https://github.com/dmlc/dmlc-core/blob/c8f7f9c81dfcf2489d3bbc6d3b2a9200a20fbcde/.travis.yml#L67-L71

Exit code is set to 0 thus flake8 not enforced. Likely nobody will check the CI log for warnings and the check is thus superfluous.

Example run: https://travis-ci.org/dmlc/dmlc-core/jobs/657898840?utm_medium=notification&utm_source=github_status