search

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.
Apache License 2.0
864 stars 520 forks source link

[Breaking] Remove optional `changed` parameter. #611

Closed trivialfis closed 4 years ago

trivialfis commented 4 years ago

I made the optional parameter for users to detect whether some parameters have been changed. So far it doesn't seem to be useful in practice, users can just save the old value and compare it themselves. Supporting this parameter requires a Same function to compare raw memory, which could be uninitialized. This results in many complains and false alarms from analyzers like clang-tidy, ubsan, valgrind.

trivialfis commented 4 years ago

The exact same error on #610 ...

trivialfis commented 4 years ago

@hcho3

hcho3 commented 4 years ago

Will merge this after all tests pass.

trivialfis commented 4 years ago

ping @hcho3