search

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.
Apache License 2.0
864 stars 520 forks source link

[Bugfix] Fix logging tests #616

Closed junrushao closed 4 years ago

junrushao commented 4 years ago

Hope this could pass the unittests :-)

@hcho3 @tqchen

junrushao commented 4 years ago

Looks like MSVC 2013 doesn't recognize thread_local

tqchen commented 4 years ago

Let us just disable msvc 2013 in here https://github.com/dmlc/dmlc-core/blob/master/appveyor.yml

hcho3 commented 4 years ago

Yes, let's drop MSVC 2013, since dmlc-core has been upgraded to C++11 standard. We need MSVC 2015+ to compile C++11.

junrushao commented 4 years ago

Thank you @hcho3 and @tqchen!