Allow GNU Make user to opt out of using execinfo.h via flag DMLC_LOG_STACK_TRACE

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.

Apache License 2.0

864 stars 519 forks source link

Allow GNU Make user to opt out of using execinfo.h via flag DMLC_LOG_STACK_TRACE #645

Closed apivovarov closed 3 years ago

apivovarov commented 3 years ago

Some platforms (e.g. OpenWRT) do not have execinfo.h in their SDK.

We should check that cxxabi.h and execinfo.h are present before enabling DMLC_LOG_STACK_TRACE by default in build_config_default.h

This check is already done in cmake/build_config.h.in. To be consistent we should also do it in build_config_default.h

apivovarov commented 3 years ago

About TVM PR-7701. TVM uses dmlc-core as a header only library. They do not want to add new "dmlc" cmake target to TVM project and build libdmlc.a library. Looks like TVM can only use build_config_default.h