search

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.
Apache License 2.0
865 stars 520 forks source link

Crosscompilation fails due to incorrect case #646

Closed qjebbs closed 1 year ago

qjebbs commented 3 years ago

Windows is case-insensitive, but when cross-compiling dmlc from Linux with the MinGW tools this causes problems, because the file is named shlwapi.h in lowercase.

include/dmlc/filesystem.h (L21)

#include <Shlwapi.h>
#pragma comment(lib, "Shlwapi.lib")

src/io/local_filesys.cc (L16)

#include <Windows.h>

same issue with this one: https://github.com/mattn/mruby-pcre-regexp/issues/7

hcho3 commented 1 year ago

Fixed in https://github.com/dmlc/dmlc-core/pull/673