search

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.
Apache License 2.0
865 stars 520 forks source link

fix tracker for python 3.9 #665

Closed rongou closed 2 years ago

rongou commented 2 years ago

Python 3.9 removed the deprecated method Thread.isAlive and replace it with Thread.is_alive.

See https://bugs.python.org/issue37804

rongou commented 2 years ago

@hcho3 @trivialfis

trivialfis commented 2 years ago

I think XGBoost is no longer using the tracker in dmlc-core.

rongou commented 2 years ago

It's still used in the distributed tests: https://github.com/dmlc/xgboost/blob/master/tests/distributed/runtests.sh#L7

trivialfis commented 2 years ago

We can copy the submit script into XGBoost as well, otherwise, there are two trackers in use. The fix looks good to me, @hcho3 can help merge it