Closed chenw23 closed 4 years ago
Merging #1184 into master will increase coverage by
0.07%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 87.34% 87.42% +0.07%
==========================================
Files 80 81 +1
Lines 7365 7346 -19
==========================================
- Hits 6433 6422 -11
+ Misses 932 924 -8
Impacted Files | Coverage Δ | |
---|---|---|
src/gluonnlp/data/corpora/google_billion_word.py | 64.70% <0.00%> (-0.52%) |
:arrow_down: |
src/gluonnlp/data/baidu_ernie_data.py | 85.71% <0.00%> (-0.26%) |
:arrow_down: |
...p/data/corpora/large_text_compression_benchmark.py | 90.56% <0.00%> (-0.18%) |
:arrow_down: |
src/gluonnlp/data/intent_slot.py | 92.30% <0.00%> (-0.12%) |
:arrow_down: |
src/gluonnlp/data/word_embedding_evaluation.py | 89.27% <0.00%> (-0.05%) |
:arrow_down: |
src/gluonnlp/data/sentiment.py | 98.26% <0.00%> (-0.03%) |
:arrow_down: |
src/gluonnlp/data/super_glue.py | 98.63% <0.00%> (-0.01%) |
:arrow_down: |
src/gluonnlp/data/glue.py | 99.08% <0.00%> (-0.01%) |
:arrow_down: |
src/gluonnlp/data/conll.py | 100.00% <0.00%> (ø) |
|
src/gluonnlp/data/translation.py | 100.00% <0.00%> (ø) |
|
... and 6 more |
Job PR-1184/1 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/1/index.html
Job PR-1184/3 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/3/index.html
Job PR-1184/4 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/4/index.html
Job PR-1184/5 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/5/index.html
Currently, I am writing this page the same style as gluon cv. I think that we are using policies for warnings: they let warnings go but we treat warnings as errors.
So for the last two columns, do you want to change CI to make them display the same command, or change the rst code to let them display different contents?
Thanks!
Job PR-1184/9 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/9/index.html
Job PR-1184/10 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/10/index.html
Job PR-1184/11 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/11/index.html
Job PR-1184/12 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/12/index.html
Job PR-1184/13 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/13/index.html
Do you want to have reference for exactly every model(which will take more work and time), or I just add reference for those already mentioned in the corresponding page?
Job PR-1184/14 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1184/14/index.html
Is it possible that we first merge this pull request and then I make updates in a new pull request? Since there has been a lot of updates on master branch, this might be less error-prone than merging a lot of commits to the current pull request.
I’m fine for merging this PR.
Get Outlook for iOShttps://aka.ms/o0ukef
From: WANG, Chen notifications@github.com Sent: Thursday, June 18, 2020 8:22:16 PM To: dmlc/gluon-nlp gluon-nlp@noreply.github.com Cc: Xingjian SHI xshiab@connect.ust.hk; Review requested review_requested@noreply.github.com Subject: Re: [dmlc/gluon-nlp] [website] Add a Catalog page for the GluonNLP trained models (#1184)
Is it possible that we first merge this pull request and then I make updates in a new pull request? Since there has been a lot of updates on master branch, this might be less error-prone than merging a lot of commits to the current pull request.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/dmlc/gluon-nlp/pull/1184#issuecomment-646413502, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABHQH3SJHYBQIL5AAEMMZV3RXLKWRANCNFSM4LM3WVWQ.
@eric-haibin-lin ping for review
Description
[website] Add a Catalog page for the GluonNLP trained models
Checklist
Essentials
Changes
Comments
cc @dmlc/gluon-nlp-team