chenw23 commented 4 years ago

Description

As we want to simplify the process of compiling the docs and website manually on a laptop machine without GPU (e.g. MacBook Pro), we want a command that can disable computing python scripts in the docs.

This pull request is a standalone change to the interface of md2ipynb file that supports converting without computing python scripts.

This change is compatible with all the existing CI and Makefile. It accepts existing commands and enables computing on default.

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

codecov[bot] commented 4 years ago

Codecov Report

Merging #1191 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          81       81           
  Lines        7345     7345           
=======================================
  Hits         6421     6421           
  Misses        924      924

mli commented 4 years ago

Job PR-1191/6 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1191/6/index.html