chenw23 commented 4 years ago

Description

I am using PyCharm for developing. I often use make docs to preview the newly built website files and use make clean to wipe all the artifacts out.

However, the make clean command removes everything in the ./idea folder, which is very unfriendly and destructive, meaning that I will need to manually set all the settings and preferences for this project.

I think the change in this pull request will benefit the PyCharm users who build the website.

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

codecov[bot] commented 4 years ago

Codecov Report

Merging #1194 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1194   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          81       81           
  Lines        7345     7345           
=======================================
  Hits         6421     6421           
  Misses        924      924

mli commented 4 years ago

Job PR-1194/1 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1194/1/index.html