dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.56k stars 538 forks source link

[BUGFIX] Fix wd in finetune_squad.py #1210

Closed eric-haibin-lin closed 4 years ago

eric-haibin-lin commented 4 years ago

Description

The command for finetune_squad.py was originally using adam without wd. Removing it from the script. Fixes https://github.com/dmlc/gluon-nlp/issues/1204

Checklist

Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

mli commented 4 years ago

Job PR-1210/1 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1210/1/index.html

codecov[bot] commented 4 years ago

Codecov Report

Merging #1210 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1210   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          81       81           
  Lines        7346     7346           
=======================================
  Hits         6422     6422           
  Misses        924      924