[v0.9][BUGFIX] Fix wd in finetune_squad.py #1210 - Githubissues

dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.56k stars 538 forks source link

[v0.9][BUGFIX] Fix wd in finetune_squad.py #1210 #1211

Closed eric-haibin-lin closed 4 years ago

eric-haibin-lin commented 4 years ago

Description

The command for finetune_squad.py was originally using adam without wd. Removing it from the script. Fixes #1204

Checklist

Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

chenw23 commented 4 years ago

Hello Haibin, please merge the latest v0.9.x branch for #1213 so that your builds can be successful.

eric-haibin-lin commented 4 years ago

moved to https://github.com/dmlc/gluon-nlp/pull/1223