dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.56k stars 538 forks source link

[v0.9][BUGFIX] Fix wd in finetune_squad.py #1223

Closed eric-haibin-lin closed 4 years ago

eric-haibin-lin commented 4 years ago

Description

The command for finetune_squad.py was originally using adam without wd. Removing it from the script. Fixes #1204 https://github.com/dmlc/gluon-nlp/pull/1211

Checklist

Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

mli commented 4 years ago

Job PR-1223/1 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1223/1/index.html

codecov[bot] commented 4 years ago

Codecov Report

Merging #1223 into v0.9.x will decrease coverage by 0.34%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           v0.9.x    #1223      +/-   ##
==========================================
- Coverage   88.86%   88.51%   -0.35%     
==========================================
  Files          72       72              
  Lines        6977     6977              
==========================================
- Hits         6200     6176      -24     
- Misses        777      801      +24

Impacted Files	Coverage Δ
src/gluonnlp/data/word_embedding_evaluation.py	`89.31% <0.00%> (-7.64%)`	:arrow_down:
src/gluonnlp/data/glue.py	`96.81% <0.00%> (-1.82%)`	:arrow_down: