dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.56k stars 538 forks source link

[BUGFIX] Remove test set from validation #1228

Closed avinashsai closed 4 years ago

avinashsai commented 4 years ago

Fixes #372

mli commented 4 years ago

Job PR-1228/1 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1228/1/index.html

codecov[bot] commented 4 years ago

Codecov Report

Merging #1228 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1228   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          81       81           
  Lines        7365     7365           
=======================================
  Hits         6441     6441           
  Misses        924      924           
avinashsai commented 4 years ago

@leezu @szha Please review this

avinashsai commented 4 years ago

Similarly, an argument should be added in train_transformer.py whether to perform inference on test set? It should be default set to true?

avinashsai commented 4 years ago

@StrayBird-ATSH GluonNLP-py3-master-gpu-doc is failing.

chenw23 commented 4 years ago

Thanks for reminding. I have noticed it on some other pull request. It might be due to some global internet connectivity failures. We are sorting out reasons.

avinashsai commented 4 years ago

@StrayBird-ATSH Any updated on this?

avinashsai commented 4 years ago

@StrayBird-ATSH can you restart builds to see if the issue has been resolved?

chenw23 commented 4 years ago

OK. I will have a look into it.

avinashsai commented 4 years ago

@StrayBird-ATSH I guess the error is fixed. If possible, can you restart builds?

chenw23 commented 4 years ago

@StrayBird-ATSH I guess the error is fixed. If possible, can you restart builds?

Yes, would you please merge the latest master branch into your pull request, especially to include #1236 ? Thanks!

mli commented 4 years ago

Job PR-1228/10 is complete. Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1228/10/index.html

avinashsai commented 4 years ago

@eric-haibin-lin please review this

eric-haibin-lin commented 4 years ago

thanks for the contribution!