dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.56k stars 538 forks source link

[Numpy] Fix SQuAD + Fix GLUE downloading #1280

Closed sxjscience closed 4 years ago

sxjscience commented 4 years ago

Description

Fix SQuAD due to the recent upgrade of MXNet: https://github.com/apache/incubator-mxnet/pull/18368 @MoisesHer Basically, the default data type of integer arrays will be int64.

Changes

[x] SQuAD Fix

cc @dmlc/gluon-nlp-team

szha commented 4 years ago

thanks for bringing this up. int64 as default is not yet enabled and there are some more work needed for that to happen.

zheyuye commented 4 years ago

I can confirm that there is a bug here as <<<MXNetError: Check failed: assign(&dattr, vec.at(i)): Incompatible attr in node _npi_stack at 1-th input: expected int32, got int64

codecov[bot] commented 4 years ago

Codecov Report

Merging #1280 into numpy will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            numpy    #1280   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files          41       41           
  Lines        6157     6157           
=======================================
  Hits         5181     5181           
  Misses        976      976