search

dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.55k stars 538 forks source link

[FEATURE]Horovod support for training transformer + add mirror data for wmt (PART 1) #1284

Closed hutao965 closed 4 years ago

hutao965 commented 4 years ago

Checklist

Essentials

Changes

codecov[bot] commented 4 years ago

Codecov Report

Merging #1284 into numpy will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            numpy    #1284      +/-   ##
==========================================
+ Coverage   83.60%   83.68%   +0.08%     
==========================================
  Files          42       42              
  Lines        6375     6382       +7     
==========================================
+ Hits         5330     5341      +11     
+ Misses       1045     1041       -4
Impacted Files Coverage Δ
src/gluonnlp/data/sampler.py 96.22% <100.00%> (+0.10%) :arrow_up:
src/gluonnlp/layers.py 86.78% <0.00%> (ø)
src/gluonnlp/embedding/embed_loader.py 81.52% <0.00%> (ø)
src/gluonnlp/utils/misc.py 44.69% <0.00%> (+1.28%) :arrow_up:
sxjscience commented 4 years ago

@hymzoque The horovod PR has been merged. Would you merge master?

sxjscience commented 4 years ago

LGTM in general, you may add some transformer_base numbers.