search

dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.55k stars 538 forks source link

Fix gelu #1287

Closed zheyuye closed 4 years ago

zheyuye commented 4 years ago

Description

Fix gelu as discussed in https://github.com/dmlc/gluon-nlp/pull/1282#discussion_r462739848 which fixed by https://github.com/apache/incubator-mxnet/pull/18827

Comments

@sxjscience

codecov[bot] commented 4 years ago

Codecov Report

Merging #1287 into numpy will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            numpy    #1287      +/-   ##
==========================================
+ Coverage   83.60%   83.67%   +0.06%     
==========================================
  Files          42       42              
  Lines        6375     6375              
==========================================
+ Hits         5330     5334       +4     
+ Misses       1045     1041       -4
Impacted Files Coverage Δ
src/gluonnlp/layers.py 86.78% <100.00%> (ø)
src/gluonnlp/utils/misc.py 44.69% <0.00%> (+1.28%) :arrow_up: