minor fix for run_electra.py & remove hybridization in the construction method - Githubissues

dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.55k stars 538 forks source link

minor fix for run_electra.py & remove hybridization in the construction method #1307

Closed ZiyueHuang closed 4 years ago

ZiyueHuang commented 4 years ago

Description

model.collect_params() returns a python dict. @sxjscience

Checklist

Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

sxjscience commented 4 years ago

I'll merge first, need to fix the dockerhub check.