barry-jin commented 4 years ago

Description

As title

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

codecov[bot] commented 4 years ago

Codecov Report

Merging #1333 into master will increase coverage by 0.21%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
+ Coverage   84.23%   84.45%   +0.21%     
==========================================
  Files          42       42              
  Lines        6426     6426              
==========================================
+ Hits         5413     5427      +14     
+ Misses       1013      999      -14

Impacted Files	Coverage Δ
src/gluonnlp/data/loading.py	`83.39% <0.00%> (+5.28%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff95fb4...d645584. Read the comment docs.

sxjscience commented 4 years ago

@szha Could you turn off branch protection temporarily and merge this in? This is now blocking the development.

dmlc / gluon-nlp

[CI] Update test file path #1333