Closed sxjscience closed 4 years ago
@szha @leezu @barry-jin @szhengac Currently I'm fixing the problem manually but we may consider to add some sagemaker-based unittests to make sure that everything works on SageMaker Notebook.
Merging #1348 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1348 +/- ##
=======================================
Coverage 81.75% 81.75%
=======================================
Files 52 52
Lines 6862 6862
=======================================
Hits 5610 5610
Misses 1252 1252
Impacted Files | Coverage Δ | |
---|---|---|
setup.py | 0.00% <ø> (ø) |
|
src/gluonnlp/data/tokenizers/subword_nmt.py | 78.50% <0.00%> (-0.94%) |
:arrow_down: |
src/gluonnlp/data/tokenizers/yttm.py | 82.75% <0.00%> (+0.86%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e0b293e...e05e77e. Read the comment docs.
Thanks @preeyank5 for reporting the issue. This should have been fixed. However, we still need to figure out the way to test on SageMaker Notebook instance.
Description
Make sure the installation works on SageMaker Notebook with
conda_python3
kernel.cc @dmlc/gluon-nlp-team