dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.55k stars 538 forks source link

[Fix] Minor fix for AMLC Tutorial - QA #1359

Closed sxjscience closed 4 years ago

sxjscience commented 4 years ago

Description

Some documentation improvement + Use dataclass

Checklist

Essentials

Changes

Comments

cc @dmlc/gluon-nlp-team

codecov[bot] commented 4 years ago

Codecov Report

Merging #1359 into master will increase coverage by 10.84%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1359       +/-   ##
===========================================
+ Coverage   70.87%   81.71%   +10.84%     
===========================================
  Files         105       52       -53     
  Lines       12483     6898     -5585     
===========================================
- Hits         8847     5637     -3210     
+ Misses       3636     1261     -2375     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/gluonnlp/utils/preprocessing.py 94.28% <50.00%> (-5.72%) :arrow_down:
src/gluonnlp/models/xlmr.py 58.82% <0.00%> (-29.42%) :arrow_down:
src/gluonnlp/models/__init__.py 67.74% <0.00%> (-29.04%) :arrow_down:
src/gluonnlp/models/electra.py 57.89% <0.00%> (-18.56%) :arrow_down:
src/gluonnlp/models/bart.py 70.62% <0.00%> (-15.63%) :arrow_down:
src/gluonnlp/utils/config.py 61.53% <0.00%> (-15.39%) :arrow_down:
src/gluonnlp/models/roberta.py 84.38% <0.00%> (-9.29%) :arrow_down:
src/gluonnlp/utils/misc.py 51.08% <0.00%> (-7.74%) :arrow_down:
src/gluonnlp/models/albert.py 87.80% <0.00%> (-7.67%) :arrow_down:
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0223686...a1f49d6. Read the comment docs.