barry-jin commented 4 years ago

Description

Fix issue #1369

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

github-actions[bot] commented 4 years ago

The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR#1370/freeze-boto3/index.html

codecov[bot] commented 4 years ago

Codecov Report

Merging #1370 into master will decrease coverage by 10.92%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1370       +/-   ##
===========================================
- Coverage   81.68%   70.76%   -10.93%     
===========================================
  Files          52      105       +53     
  Lines        6906    12518     +5612     
===========================================
+ Hits         5641     8858     +3217     
- Misses       1265     3660     +2395

Impacted Files	Coverage Δ
src/gluonnlp/data/loading.py	`78.11% <0.00%> (-5.29%)`	:arrow_down:
tests/test_models.py	`100.00% <0.00%> (ø)`
scripts/processing/clean_tok_mono_corpus.py	`0.00% <0.00%> (ø)`
tests/test_data_vocab.py	`99.03% <0.00%> (ø)`
...ripts/datasets/question_answering/prepare_squad.py	`0.00% <0.00%> (ø)`
scripts/processing/apply_subword.py	`88.69% <0.00%> (ø)`
tests/test_data_batchify.py	`100.00% <0.00%> (ø)`
tests/test_initializer.py	`92.59% <0.00%> (ø)`
tests/test_models_roberta.py	`100.00% <0.00%> (ø)`
...ts/datasets/question_answering/prepare_searchqa.py	`0.00% <0.00%> (ø)`
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56de303...918f233. Read the comment docs.