hutao965 commented 4 years ago

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[x] record latest result of transformer nmt

cc @dmlc/gluon-nlp-team

github-actions[bot] commented 4 years ago

The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1373/master/index.html

codecov[bot] commented 4 years ago

Codecov Report

Merging #1373 into master will increase coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1373      +/-   ##
==========================================
+ Coverage   70.80%   70.91%   +0.11%     
==========================================
  Files         105      106       +1     
  Lines       12518    12568      +50     
==========================================
+ Hits         8863     8913      +50     
  Misses       3655     3655

Impacted Files	Coverage Δ
src/gluonnlp/cli/average_checkpoint.py	`93.75% <100.00%> (ø)`
tests/test_models.py	`100.00% <100.00%> (ø)`
src/gluonnlp/data/filtering.py	`78.26% <0.00%> (-4.35%)`	:arrow_down:
src/gluonnlp/data/loading.py	`81.13% <0.00%> (+3.01%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6e63f3...7de65b5. Read the comment docs.

sxjscience commented 4 years ago

Would you try to write a test case for gluon_average_checkpoint? You may refer to the example in https://github.com/dmlc/gluon-nlp/blob/master/tests/process_cli/test_learn_apply_subword.py. Basically, you can import the CLI and run the cli tool in python.

hutao965 commented 4 years ago

Would you try to write a test case for gluon_average_checkpoint? You may refer to the example in https://github.com/dmlc/gluon-nlp/blob/master/tests/process_cli/test_learn_apply_subword.py. Basically, you can import the CLI and run the cli tool in python.

ok

github-actions[bot] commented 4 years ago

The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1373/master/index.html

github-actions[bot] commented 4 years ago

The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1373/master/index.html

github-actions[bot] commented 4 years ago

The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1373/master/index.html

github-actions[bot] commented 4 years ago

The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1373/master/index.html

github-actions[bot] commented 4 years ago

The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1373/master/index.html

github-actions[bot] commented 4 years ago