Closed ZiyueHuang closed 3 years ago
The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1376/bert/index.html
Merging #1376 into master will decrease coverage by
0.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
- Coverage 71.09% 71.04% -0.05%
==========================================
Files 107 107
Lines 12607 12607
==========================================
- Hits 8963 8957 -6
- Misses 3644 3650 +6
Impacted Files | Coverage Δ | |
---|---|---|
src/gluonnlp/data/filtering.py | 78.26% <0.00%> (-4.35%) |
:arrow_down: |
src/gluonnlp/data/tokenizers/yttm.py | 81.89% <0.00%> (-0.87%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4fb41d7...9f83ab7. Read the comment docs.
The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1376/bert/index.html
The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1376/bert/index.html
LGTM overall. But we may later need to consider to merge the Electra + Bert (nsp + mlm) + Albert (sop + mlm) implementations.
Would you try to merge the upstream/master? It seems that there's something wrong in the GPU test.
Would you try to merge the upstream/master? It seems that there's something wrong in the GPU test.
done
The documentation website for preview: http://gluon-nlp-dev.s3-accelerate.amazonaws.com/PR1376/bert/index.html
Description
@sxjscience
Checklist
Essentials
Changes
Comments
cc @dmlc/gluon-nlp-team