Closed bgawrych closed 3 years ago
LGTM. Thanks for the fix!
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1392/benchmark_fix/index.html
Merging #1392 into master will increase coverage by
0.11%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1392 +/- ##
==========================================
+ Coverage 85.12% 85.24% +0.11%
==========================================
Files 53 53
Lines 6959 6959
==========================================
+ Hits 5924 5932 +8
+ Misses 1035 1027 -8
Impacted Files | Coverage Δ | |
---|---|---|
src/gluonnlp/data/filtering.py | 78.26% <0.00%> (-4.35%) |
:arrow_down: |
src/gluonnlp/data/tokenizers/yttm.py | 81.89% <0.00%> (-0.87%) |
:arrow_down: |
src/gluonnlp/data/loading.py | 83.39% <0.00%> (+5.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8ef4b26...deb6ca9. Read the comment docs.
Description
When I tried to run benchmarks only with CPU I got NaNs in results:
The reason was that MemoryMeasureProcess class was defined inside function. This PR moves MemoryMeasureProcess class and _get_cpumemory function outside of _measure_peak_memorycpu function what solves the problem.
Checklist
Essentials
cc @dmlc/gluon-nlp-team @sxjscience