barry-jin commented 3 years ago

Description

Commit changes after updating the docker by setting MXNet to latest version in AWS Batch CI.

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

codecov[bot] commented 3 years ago

Codecov Report

Merging #1414 into master will increase coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage   85.24%   85.33%   +0.08%     
==========================================
  Files          53       53              
  Lines        6954     6954              
==========================================
+ Hits         5928     5934       +6     
+ Misses       1026     1020       -6

Impacted Files	Coverage Δ
src/gluonnlp/data/tokenizers/yttm.py	`82.75% <0.00%> (+0.86%)`	:arrow_up:
src/gluonnlp/data/filtering.py	`82.60% <0.00%> (+4.34%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0484e64...8891e10. Read the comment docs.

sxjscience commented 3 years ago

How about to merge this PR with the doc improvement PR?

barry-jin commented 3 years ago

I have just merged this branch to doc improvement branch.