dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.56k stars 538 forks source link

[Bugfix] Fix prepare_wikipedia #1417

Closed sxjscience closed 3 years ago

sxjscience commented 3 years ago

Description

Checklist

Essentials

cc @dmlc/gluon-nlp-team

sxjscience commented 3 years ago

Fix https://github.com/dmlc/gluon-nlp/issues/1416

FYI @preeyank5

codecov[bot] commented 3 years ago

Codecov Report

Merging #1417 into master will decrease coverage by 0.62%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
- Coverage   85.24%   84.62%   -0.63%     
==========================================
  Files          53       53              
  Lines        6954     6868      -86     
==========================================
- Hits         5928     5812     -116     
- Misses       1026     1056      +30     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/gluonnlp/utils/lazy_imports.py 57.95% <66.66%> (-1.81%) :arrow_down:
conftest.py 76.31% <0.00%> (-9.94%) :arrow_down:
src/gluonnlp/data/loading.py 75.75% <0.00%> (-7.64%) :arrow_down:
src/gluonnlp/utils/misc.py 58.25% <0.00%> (-0.95%) :arrow_down:
src/gluonnlp/data/tokenizers/spacy.py 65.33% <0.00%> (-0.91%) :arrow_down:
src/gluonnlp/data/tokenizers/huggingface.py 72.44% <0.00%> (-0.47%) :arrow_down:
src/gluonnlp/models/transformer_xl.py 82.00% <0.00%> (-0.45%) :arrow_down:
src/gluonnlp/data/tokenizers/jieba.py 73.13% <0.00%> (-0.40%) :arrow_down:
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0484e64...4e1a569. Read the comment docs.