dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.56k stars 538 forks source link

[CI][DOC] Improve website build process + Fix doc #1418

Closed barry-jin closed 3 years ago

barry-jin commented 3 years ago

Description

  1. Notebook fails compilation will be shown in CI and developers can download build artifacts to find the error message.
  2. After #1356 is merged, tutorials question_answering and text_prediction_part2 will fail the notebook compilation because these notebooks need to be updated. Now both of them are updated.

Checklist

Essentials

Changes

Comments

cc @dmlc/gluon-nlp-team

codecov[bot] commented 3 years ago

Codecov Report

Merging #1418 into master will decrease coverage by 0.18%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   85.24%   85.05%   -0.19%     
==========================================
  Files          53       53              
  Lines        6954     6987      +33     
==========================================
+ Hits         5928     5943      +15     
- Misses       1026     1044      +18     
Impacted Files Coverage Δ
src/gluonnlp/attention_cell.py 80.39% <0.00%> (ø)
src/gluonnlp/data/loading.py 78.11% <0.00%> (-5.29%) :arrow_down:
src/gluonnlp/utils/lazy_imports.py 66.08% <0.00%> (+6.33%) :arrow_up:
src/gluonnlp/base.py 96.66% <0.00%> (+6.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0484e64...a7cfa4e. Read the comment docs.

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1418/improve-ci2/index.html

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1418/improve-ci2/index.html

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1418/improve-ci2/index.html

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1418/improve-ci2/index.html