search

dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.56k stars 538 forks source link

npx.save -> npx.savez #1441

Closed leezu closed 3 years ago

leezu commented 3 years ago

Update for https://github.com/apache/incubator-mxnet/commit/5dc404dfb0cb5e9a034c9db5d58721e15791ad33

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1441/npx.savez/index.html

sxjscience commented 3 years ago

We can merge after the nightly has been updated.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1441 (e3bda2f) into master (f5c5b73) will increase coverage by 0.27%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   85.37%   85.64%   +0.27%     
==========================================
  Files          53       53              
  Lines        6987     6987              
==========================================
+ Hits         5965     5984      +19     
+ Misses       1022     1003      -19
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/gluonnlp/cli/average_checkpoint.py 93.75% <100.00%> (ø)
src/gluonnlp/data/filtering.py 82.60% <0.00%> (+4.34%) :arrow_up:
src/gluonnlp/data/loading.py 83.39% <0.00%> (+5.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5c5b73...e3bda2f. Read the comment docs.

sxjscience commented 3 years ago

@leezu Do you know what's the status of this PR?

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1441/npx.savez/index.html

szha commented 3 years ago

Rerunning the timed-out build to see if 20201127 wheel includes the miniz fix.

sxjscience commented 3 years ago

The speed is still slow I think. For the previous run, it took 1hour for completing the GPU test.

szha commented 3 years ago

I think the timeout issue due to serialization has been fixed (thanks @leezu). @sxjscience any idea about the name errors in the failed tests?

sxjscience commented 3 years ago

Does the 20201127 build include the miniz fix?

sxjscience commented 3 years ago

@szha The error message should be related to wikiextractors: Seems that the 3.0.0 version contains this bug. We will need to force the dependency to wikiextractors==0.1.