szha commented 3 years ago

Description

adjust logo size to reduce the margin

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)

Changes

[x] adjust logo size

cc @dmlc/gluon-nlp-team

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html

codecov[bot] commented 3 years ago

Codecov Report

Merging #1450 (f3f1dd9) into master (c6db365) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files          53       53           
  Lines        6987     6987           
=======================================
  Hits         5975     5975           
  Misses       1012     1012

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6db365...f3f1dd9. Read the comment docs.

szha commented 3 years ago

let's rely on the website preview for making sure the logo is of the correct size

sxjscience commented 3 years ago

Actually, can we make it smaller?

szha commented 3 years ago

@sxjscience do you mean with more padding?

sxjscience commented 3 years ago

Yes, more padding.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Sheng Zha notifications@github.com Sent: Thursday, December 3, 2020 1:35:04 PM To: dmlc/gluon-nlp gluon-nlp@noreply.github.com Cc: Xingjian SHI xshiab@connect.ust.hk; Mention mention@noreply.github.com Subject: Re: [dmlc/gluon-nlp] [WEBSITE] adjust logo size (#1450)

@sxjsciencehttps://github.com/sxjscience do you mean with more padding?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dmlc/gluon-nlp/pull/1450#issuecomment-738333430, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABHQH3X3BFYPLWZJGCTCTSLSTAAARANCNFSM4ULNPL7Q.

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html

szha commented 3 years ago

looks like we still need a bit more padding on the top?

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html

szha commented 3 years ago

@sxjscience looks like some pyarrow-based datasets failed their tests. perhaps the data source has expired.

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1450/logo_size/index.html