sxjscience commented 3 years ago

Description

[x] Use the new masked_softmax and masked_logsoftmax operator
[x] Remove AdamW

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

cc @dmlc/gluon-nlp-team

codecov[bot] commented 3 years ago

Codecov Report

Merging #1457 (828303a) into master (d4a1d5d) will increase coverage by 0.49%. The diff coverage is 72.22%.

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   85.30%   85.79%   +0.49%     
==========================================
  Files          53       52       -1     
  Lines        6987     6855     -132     
==========================================
- Hits         5960     5881      -79     
+ Misses       1027      974      -53

Impacted Files	Coverage Δ
src/gluonnlp/__init__.py	`100.00% <ø> (ø)`
src/gluonnlp/attention_cell.py	`86.91% <72.22%> (+6.52%)`	:arrow_up:
src/gluonnlp/data/filtering.py	`78.26% <0.00%> (-4.35%)`	:arrow_down:
src/gluonnlp/data/tokenizers/yttm.py	`81.89% <0.00%> (-0.87%)`	:arrow_down:
src/gluonnlp/data/tokenizers/subword_nmt.py	`79.43% <0.00%> (+0.93%)`	:arrow_up:
src/gluonnlp/data/loading.py	`83.39% <0.00%> (+7.54%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4a1d5d...828303a. Read the comment docs.