dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.56k stars 538 forks source link

[Fix] Fix an issue introduced in the previous benchmark fix PR. #1462

Closed sxjscience closed 3 years ago

sxjscience commented 3 years ago

Description

Confirmed that FP32 + FP16 + Train + Inference + Torchscript work for transformers>=4.0.0 and pytorch-1.7

Checklist

Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

codecov[bot] commented 3 years ago

Codecov Report

Merging #1462 (c46db37) into master (7c1de88) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1462   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          52       52           
  Lines        6855     6855           
=======================================
  Hits         5882     5882           
  Misses        973      973

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c1de88...c46db37. Read the comment docs.

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1462/fix_benchmark2/index.html