search

dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.55k stars 538 forks source link

Speed up downloads from S3 bucket #1467

Closed leezu closed 3 years ago

leezu commented 3 years ago

Rely on boto3 by default for downloads from S3. Handle unauthenticated access to S3 via botocore if needed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1467 (cf2903e) into master (12f6da2) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
+ Coverage   85.84%   85.86%   +0.02%     
==========================================
  Files          52       52              
  Lines        6907     6911       +4     
==========================================
+ Hits         5929     5934       +5     
+ Misses        978      977       -1
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/gluonnlp/base.py 100.00% <100.00%> (+3.33%) :arrow_up:
src/gluonnlp/utils/lazy_imports.py 60.67% <100.00%> (+0.44%) :arrow_up:
src/gluonnlp/utils/misc.py 53.76% <100.00%> (+0.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12f6da2...cf2903e. Read the comment docs.

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1467/s3/index.html

sxjscience commented 3 years ago

@Cli212 After this gets merged, we can directly add Natural Question to the GluonNLP Dataset.