Closed Cli212 closed 3 years ago
Merging #1469 (3298a41) into master (def0d70) will decrease coverage by
0.18%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
- Coverage 85.86% 85.67% -0.19%
==========================================
Files 52 52
Lines 6911 6920 +9
==========================================
- Hits 5934 5929 -5
- Misses 977 991 +14
Impacted Files | Coverage Δ | |
---|---|---|
src/gluonnlp/data/loading.py | 78.11% <0.00%> (-5.29%) |
:arrow_down: |
src/gluonnlp/op.py | 95.71% <0.00%> (+0.63%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update def0d70...3298a41. Read the comment docs.
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1469/add_NQ/index.html
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1469/add_NQ/index.html
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1469/add_NQ/index.html
Description
This PR commits the script for downloading NaturalQuestions from s3 bucket. And also, instructions for using this script is written in README.md.
Additionally, I found that if we want to download triviaqa data, we should use command
python3 prepare_triviaqa.py --type {rc,unfiltered}
rather thanpython3 prepare_triviaqa.py --version {rc,unfiltered}
which README.md shows. So I update this part in README.md too.Checklist
Essentials
cc @dmlc/gluon-nlp-team