dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.55k stars 538 forks source link

[CI] Solve CI Vulnerability #1492

Closed barry-jin closed 3 years ago

barry-jin commented 3 years ago

Description

Avoid using shell scripts in CI workflow to prevent potential attacks.

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

codecov[bot] commented 3 years ago

Codecov Report

Merging #1492 (dc05918) into master (c582b64) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1492   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files          52       52           
  Lines        6909     6909           
=======================================
  Hits         5664     5664           
  Misses       1245     1245

Impacted Files	Coverage Δ
setup.py	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c582b64...dc05918. Read the comment docs.

barry-jin commented 3 years ago

PR is ready for review.