xinyual commented 3 years ago

Description

(Brief description on what this PR is about)

Checklist

Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1500/9853cec68db6daac2c5697860349aba841d8196a/index.html

codecov[bot] commented 3 years ago

Codecov Report

Merging #1500 (8d99c52) into master (f44ec96) will increase coverage by 0.10%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
+ Coverage   86.35%   86.46%   +0.10%     
==========================================
  Files          54       55       +1     
  Lines        7388     7741     +353     
==========================================
+ Hits         6380     6693     +313     
- Misses       1008     1048      +40

Impacted Files	Coverage Δ
src/gluonnlp/data/loading.py	`78.11% <0.00%> (-5.29%)`	:arrow_down:
src/gluonnlp/models/t5.py	`92.74% <0.00%> (-0.92%)`	:arrow_down:
src/gluonnlp/models/transformer.py	`98.32% <0.00%> (-0.21%)`	:arrow_down:
src/gluonnlp/models/__init__.py	`100.00% <0.00%> (ø)`
src/gluonnlp/models/mt5.py	`95.49% <0.00%> (ø)`
src/gluonnlp/data/tokenizers/huggingface.py	`71.83% <0.00%> (+0.28%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f44ec96...8d99c52. Read the comment docs.