search

dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.55k stars 538 forks source link

Update wikiextractor version #1535

Closed DOUDOU0314 closed 3 years ago

DOUDOU0314 commented 3 years ago

Description

The latest wikiextractor version 3.0.4 is compatible with our code, do change the version number directly.

cc @dmlc/gluon-nlp-team

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1535/b1a94ea91237791825c43237ffd32c0a42a3cb03/index.html

codecov[bot] commented 3 years ago

Codecov Report

Merging #1535 (7564e40) into master (58374ec) will decrease coverage by 0.63%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1535      +/-   ##
==========================================
- Coverage   82.13%   81.49%   -0.64%     
==========================================
  Files          68       68              
  Lines        8540     8414     -126     
==========================================
- Hits         7014     6857     -157     
- Misses       1526     1557      +31
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
conftest.py 76.31% <0.00%> (-9.94%) :arrow_down:
src/gluonnlp/data/loading.py 76.55% <0.00%> (-7.39%) :arrow_down:
src/gluonnlp/utils/lazy_imports.py 58.42% <0.00%> (-2.25%) :arrow_down:
src/gluonnlp/torch/models/transformer.py 27.23% <0.00%> (-0.92%) :arrow_down:
src/gluonnlp/data/tokenizers/spacy.py 65.33% <0.00%> (-0.91%) :arrow_down:
src/gluonnlp/utils/misc.py 54.09% <0.00%> (-0.78%) :arrow_down:
src/gluonnlp/data/tokenizers/huggingface.py 71.06% <0.00%> (-0.78%) :arrow_down:
src/gluonnlp/data/tokenizers/jieba.py 73.13% <0.00%> (-0.40%) :arrow_down:
src/gluonnlp/models/transformer_xl.py 80.48% <0.00%> (-0.39%) :arrow_down:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58374ec...7564e40. Read the comment docs.

sxjscience commented 3 years ago

@DOUDOU0314 I think you may rebase to the current master and we can merge.

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1535/7564e40cfa0937990b31382130932d6cd1e88ce8/index.html