[BUGFIX] Fix bug in issue #1570 - Githubissues

dmlc / gluon-nlp

NLP made easy

https://nlp.gluon.ai/

Apache License 2.0

2.56k stars 538 forks source link

[BUGFIX] Fix bug in issue #1570 #1572

Closed DOUDOU0314 closed 3 years ago

DOUDOU0314 commented 3 years ago

Description

(Brief description on what this PR is about) fix bug in issue #1570: XLMR Conversion fails on parameter dictionary KeyError

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

I modified parameters name in latest version of fairseq

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

leezu commented 3 years ago

website-build CI failed with

[2021-05-20T06:26:19.155Z] Configuration error:
[2021-05-20T06:26:19.155Z] Unknown key(s) in sphinx_gallery_conf:
[2021-05-20T06:26:19.155Z] 'find_mayavi_figures'

FYI @barry-jin

sxjscience commented 3 years ago

@DOUDOU0314 Would you merge the master and also attach the current version of fairseq?

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1572/bd7c425c9862eaf44214958f5e31c1f338729e4a/index.html

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1572/9d01554130140845e1ef132de082da2d1a249470/index.html

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1572/92546ae5d45e7c0e202eb6ffe5cbfa1dfbc7d3b3/index.html

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1572/821055398d885950205c6263985d18cfd8c4fe13/index.html

DOUDOU0314 commented 3 years ago

@DOUDOU0314 Would you merge the master and also attach the current version of fairseq? I've attached a stable version of fairseq, in which the former parameters name can be retained. And fix a bug under this version.

github-actions[bot] commented 3 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1572/3c16b68d22e205497d2eba26fcadc85f0ea5658b/index.html