dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.56k stars 538 forks source link

[TEST] Add statistical inference for Truncated Gumbel distribution #1578

Closed AetherPrior closed 2 years ago

AetherPrior commented 2 years ago

Description

Attempts to fix #1299 using statistical inference

Checklist

Essentials

Changes

Comments

Brief description of the test

Method

  1. We first attempt to verify that all the samples have values under the threshold
  2. Then, we undo the truncation, with the help of the implementation of trunc_gumbel in src/gluonnlp/op.py and then sample another gumbel distribution

Note

cc @dmlc/gluon-nlp-team

github-actions[bot] commented 2 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1578/bd0cb75943156f5a5369e4e7ab7896e87962dbc0/index.html

AetherPrior commented 2 years ago

Tagging @szha and @zheyuye

github-actions[bot] commented 2 years ago

The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1578/5bd7e3c8f69b6ea0fb81631fd0d2d44c0fc3172f/index.html

AetherPrior commented 2 years ago

Thank you for your approval of my PR. The build checks have passed. I request for the pull request to be merged and #1299 to be closed.