search

dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.56k stars 535 forks source link

Difference in naming convention between op.py and test_op.py #1580

Open AetherPrior opened 3 years ago

AetherPrior commented 3 years ago

Description

Mxnet's NumPy is being imported as np in the file src/gluonnlp/op.py:
https://github.com/dmlc/gluon-nlp/blob/5d4bc9eba7226ea9f9aabbbd39e3b1e886547e48/src/gluonnlp/op.py#L8

While NumPy is imported as np in test_op.py:
https://github.com/dmlc/gluon-nlp/blob/5d4bc9eba7226ea9f9aabbbd39e3b1e886547e48/tests/test_op.py#L1

This requires a change in conventions between tests and code, which can be a minor nuisance.

What have you tried to solve it?

  1. While a simple refactoring is possible, I don't want to be reverting any design decision in any way.