search

dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.55k stars 538 forks source link

[MODEL] contrib wanted about text classification #437

Open NonvolatileMemory opened 5 years ago

NonvolatileMemory commented 5 years ago

Hello, There are two students focus on text classification and mxnet.

We use mxnet to re-implement one ICLR 2018 paper and we have a paper accepted by AAAI 2019 also about text classification.

The two referred repos:

[1]: ICLR 2018 https://github.com/zhaozhengChen/RegionEmbedding [2]: AAAI 2019 https://github.com/NonvolatileMemory/AAAI_2019_EXAM

Thanks

szha commented 5 years ago

Congrats on the paper! These contributions would be very welcome.

NonvolatileMemory commented 5 years ago

thx, but should we modify sth in the code to make it consistent with this project.

szha commented 5 years ago

Admittedly this is a bit vague at the moment. We appreciate code with good structure and good engineering practices such as proper encapsulation and good testing. Specific for training scripts we've been getting feedback on how things could be better, which might be useful to you. Such feedback can be found in #382

NonvolatileMemory commented 5 years ago

thx a lot, I will check it.