dmlc / gluon-nlp

NLP made easy
https://nlp.gluon.ai/
Apache License 2.0
2.55k stars 538 forks source link

[BiDAF-Model] Refactor BiDAF model implementation #537

Open cgraywang opened 5 years ago

cgraywang commented 5 years ago

-Make embedding layer share the implementation with QANet -Make attention layer share the implemention with QANet

cgraywang commented 5 years ago

@Ishitori will lead the efforts on this issue, thanks!