dmlc / minpy

NumPy interface with mixed backend execution

https://minpy.readthedocs.io/en/latest/

Other

1.11k stars 112 forks source link

Fix aux state #171

Closed lryta closed 7 years ago

lryta commented 7 years ago

169 @GaiYu0 Please check if this fixes your issue.

You can checkout to this branch to see if the fix works.

lryta commented 7 years ago

@jermainewang @hotpxl Something wrong with lint?

GaiYu0 commented 7 years ago

@lryta Thank you for help! Although it appears that your commit cannot work, the issue is settled after I insert another few lines into core.py. Since there appears to be other issues preventing you from merging changes into master branch, I will push my changes to model_builder branch first.

GaiYu0 commented 7 years ago

@lryta @HrWangChengdu Here are my changes: https://github.com/dmlc/minpy/commit/3b3f36af1f94a0530439b7f4f7a026f60ca17951#diff-607de3cc1ed66be6668d3c683ec27175 https://github.com/dmlc/minpy/commit/bd3dfde049bcb9e046c97e1db97646e0e70052a1#diff-607de3cc1ed66be6668d3c683ec27175

Not sure whether these changes will cause side effects though.

Taco-W commented 7 years ago

@lryta Could you please check Alex's Code?