dmlc / treelite

Universal model exchange and serialization format for decision tree forests
https://treelite.readthedocs.io/en/latest/
Apache License 2.0
730 stars 98 forks source link

Set type fields in ConcatenateModelObjects() #475

Closed hcho3 closed 1 year ago

hcho3 commented 1 year ago

Closes #474

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.35 :warning:

Comparison is base (160ea86) 84.99% compared to head (a77ba0a) 84.65%.

:exclamation: Current head a77ba0a differs from pull request most recent head da542a0. Consider uploading reports for the commit da542a0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mainline #475 +/- ## ============================================== - Coverage 84.99% 84.65% -0.35% Complexity 42 42 ============================================== Files 112 111 -1 Lines 9851 8802 -1049 Branches 616 40 -576 ============================================== - Hits 8373 7451 -922 + Misses 1455 1328 -127 Partials 23 23 ``` | [Impacted Files](https://codecov.io/gh/dmlc/treelite/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc) | Coverage Δ | | |---|---|---| | [src/model\_concat.cc](https://codecov.io/gh/dmlc/treelite/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc#diff-c3JjL21vZGVsX2NvbmNhdC5jYw==) | `95.65% <100.00%> (ø)` | | | [tests/cpp/test\_model\_concat.cc](https://codecov.io/gh/dmlc/treelite/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc#diff-dGVzdHMvY3BwL3Rlc3RfbW9kZWxfY29uY2F0LmNj) | `100.00% <100.00%> (ø)` | | ... and [67 files with indirect coverage changes](https://codecov.io/gh/dmlc/treelite/pull/475/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.